VPS-43/Undefined Bug #221
Merged
VPS-43/Undefined Bug #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choden-dev
reviewed
Aug 15, 2024
frontend/src/containers/pages/PlayScenarioPage/PlayScenarioPage.jsx
Outdated
Show resolved
Hide resolved
frontend/src/containers/pages/PlayScenarioPage/PlayScenarioPage.jsx
Outdated
Show resolved
Hide resolved
frontend/src/containers/pages/PlayScenarioPage/PlayScenarioPage.jsx
Outdated
Show resolved
Hide resolved
frontend/src/containers/pages/PlayScenarioPage/PlayScenarioPageMulti.jsx
Outdated
Show resolved
Hide resolved
choden-dev
approved these changes
Aug 15, 2024
harbassan
force-pushed
the
undefined-bug
branch
from
cbd3b79 to
cac4c6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the issue
In certain situations, such as when a user refreshes on the the invalid-role page, the url resolves to
play/.../multiplayer/undefinedand an infinite loading screen is shown.Describe the solution
The error responses from the
/navigateendpoint weren't being handled properly in thePlayScenarioPage&PlayScenarioPageMulticomponents, because in situations where it was also the mount of the component it would still attempt to redirect the user to the given scene, which in this case wasundefined.Also added a new generic error page, as opposed to a blank screen.
Full bug analysis on the confluence page.
Risk
No conflict risks, however the problem may not be completely solved (see confluence).
Definition of Done
Reviewed By
Who reviewed your PR - for commit history once merged