Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VPS-13] Design login page #204

Merged
merged 2 commits into from
Jul 21, 2024
Merged

[VPS-13] Design login page #204

merged 2 commits into from
Jul 21, 2024

Conversation

itsatulbox
Copy link
Contributor

Describe the issue

We need a login page to load to when the user is logged out which links to the Google Firebase login.

Describe the solution

Design was created for the page and went through two versions. Second version was chosen as it is more eye catching and also matches layout of the SceneSelectionPage.

Design #1
image
Design #2
image

Through development, page design was slightly modified. Sidebar colour was corrected to the same as the SceneSelection page. Login page title and description was centered and made closer together. Background image was added.

Finished design
image

Risk

The Sidebar CSS file which was used in the SceneSelectionPage was changed which shouldn't but could impact the SceneSelectionPage. Page is new so shouldn't impact anything else.

Definition of Done

  • Code peer-reviewed
  • Wiki Documentation is written and up to date
  • Unit tests written and passing
  • Integration tests written and passing
  • Continuous Integration build passing
  • Acceptance criteria met
  • Deployed to production environment

Reviewed By

Who reviewed your PR - for commit history once merged

Copy link
Contributor

@codecreator127 codecreator127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@wjin-lee wjin-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic Job!

@itsatulbox itsatulbox merged commit 58baaf4 into master Jul 21, 2024
6 checks passed
@itsatulbox itsatulbox deleted the VPS-13/design-login-page branch July 21, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants