[VPS-24M1] Last minute fixes for Milestone One #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjin-lee
requested review from
codecreator127,
xche529,
JordanBlenn and
jacobmathew105
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This PR aims to address three main issues:
Implementation Notes
CSV upload now informs the user on outcome via toast messages.
The view notes button is more prominently displayed for usability.
Risks
This is a last minute change with minimal testing other than through the main critical path for milestone 1 - i.e. CSV upload -> scene permissions edit -> simple play demo. There could be untested bugs, and breaking changes.