Vps 170/connecting the csv upload file to the upload csv button #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using Papa.parse the csv is iterated through and all students with the same group number are sorted into a list, part of a larger list of groups. Validation exists for empty strings and lines.
wjin-lee
deleted the
VPS-170/Connecting-the-CSV-upload-file-to-the-Upload-CSV-Button
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the issue
Non-functional upload button
Groups data from csv upload not saved anywhere
Manage Groups table inside scenarios not displayed on the website
Describe the solution
Upload button within each scenario takes a csv file. Parse the csv, and depending on assigned group number within csv, group users. Made into a 2D array which is a list of all groups which has a list of users within each group. Parsed JSON sent to backend where upon successful validation, is stored. Each upload has alerts informing whether the upload was successful or not.
Data is displayed appropriately in the manage groups table, mapped using unique emails (or index if there are email duplicates).
Risk
Potential merge conflicts in backend.
Possibly too many alerts.
Definition of Done
Reviewed By
Who reviewed your PR - for commit history once merged