Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vps 75/when a scenario is being deleted, a pop up appears to prevent the user from deleting a scenario by accident #192

Conversation

jacobmathew105
Copy link
Contributor

@jacobmathew105 jacobmathew105 commented May 27, 2024

Describe the issue

When a user selects a scenario accidentally clicks delete, the whole scenario is deleted without confirmation.

Describe the solution

A pop-up appears to prevent the user from deleting a scenario by accident. The user can go back to the scene selection or confirm that they want to delete the page.
Removed the deletebuttonjsx from the sideBar.jsx page and implemented it in the deletemodal.jsx.
image

Risk

Merge conflicts.

Definition of Done

  • Code peer-reviewed
  • Wiki Documentation is written and up to date
  • Unit tests written and passing
  • Integration tests written and passing
  • Continuous Integration build passing
  • Acceptance criteria met
  • Deployed to production environment

Reviewed By

Who reviewed your PR - for commit history once merged

Issue: A standalone page is required to redirect to when the user tries to access a scene that their role cannot access

Solution: A page is implemented with a back button to the scene scenario selection page
Replaced the deletebutton with a deletemodal on the sidebar
Copy link
Contributor

@JordanBlenn JordanBlenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

Copy link
Member

@wjin-lee wjin-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

REMINDER: This PR has non-conventional commit messages. I will reject PRs and enforce history rewrite in the future.
image

@jacobmathew105 jacobmathew105 merged commit 0c8c16d into master May 29, 2024
6 checks passed
@jacobmathew105 jacobmathew105 deleted the VPS-75/When-a-scenario-is-being-deleted,-a-pop-up-appears-to-prevent-the-user-from-deleting-a-scenario-by-accident branch May 29, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants