Fix ReloadAccounts if accounts are removed

The logic handling the removal of accounts will skip
checking the next account whenever one is being removed
from the slice. If there's 2 in a row to remove, the
2nd one won't get removed. This fixes it.

This also removes duplicate err checking in LoadKojiAreas().

accounts/accountManager.go

@@ -5,10 +5,11 @@ import (
 	"flygon/config"
 	"flygon/db"
 	"flygon/pogo"
-	log "github.com/sirupsen/logrus"
-	"gopkg.in/guregu/null.v4"
 	"sync"
 	"time"
+
+	log "github.com/sirupsen/logrus"
+	"gopkg.in/guregu/null.v4"
 )
 
 type AccountDetails struct {
@@ -86,6 +87,8 @@ func (a *AccountManager) ReloadAccounts() {
 			a.accounts = append(a.accounts[:x], a.accounts[x+1:]...)
 			a.inUse = append(a.inUse[:x], a.inUse[x+1:]...)
 			foundRecords = append(foundRecords[:x], foundRecords[x+1:]...)
+			// 'x' now points to next record, so we need to repeat
+			x--
 		}
 	}
 }

koji/main.go

@@ -92,10 +92,6 @@ func LoadKojiAreas(details *db.DbDetails) {
 		return
 	}
 
-	if err != nil {
-		log.Errorf("[KOJI]: %s", err)
-		return
-	}
 	var backgroundProcesses sync.WaitGroup
 
 	parallelSem := make(chan bool, 50)