fix: posting metrics fails due to stop being null #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gastonfournier
commented
Mar 1, 2024
Comment on lines
+87
to
+89
| val bucketRef = bucket | ||
| bucket = Bucket(start = stop) | ||
| val clonedMetrics = bucketRef.copy(stop = stop) |
There was a problem hiding this comment.
Immediately swap variables so new counts are against the new bucket, only then make a copy. If due to a race condition a count is still counted against the old bucket it'll still be counted, so we should not lose data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
When posting metrics the stop variable of the bucket is null. This makes Unleash reject metrics with a 400 error.
This PR fixes that and adds a test validating the body format