Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to remove toggle listeners that you have added #69

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

StylianosGakis
Copy link
Contributor

About the changes

This adds two new public functions to RefreshPolicy, and by extension to UnleashClientSpec so that the caller can call them.

Closes #68

Discussion points

I have not added remove functions for the other listeners, as they do not currently expose a function to add listeners through the UnleashClientSpec.
I have added a test to RefreshPolicyTest itself to ensure that adding and removing the listener works as expected.

The first commit fixes a little bug I think was there regarding what object was used for synchronization, which I think was simply a misspell. If that was not the case feel free to either revert that yourself or let me know so I can do it.

@nunogois nunogois requested a review from chriswk February 1, 2024 11:14
Copy link
Member

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nunogois nunogois merged commit 1b6adb6 into Unleash:main Feb 1, 2024
2 checks passed
@StylianosGakis
Copy link
Contributor Author

Thank you for merging this in!
As a follow up question here, what do you typically do regarding release cycles of the SDK? Is there a standard cycle that you make a new release in if there are changes to be released, do you do it when you got something bigger going, or what do you do in general?

I am trying to understand when I could expect this change to be included in the latest release, since I do not see anything related to snapshot releases or something like that which would allow me to use this before the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It is impossible to remove added listeners that are trying to listen in on changes to the feature flags
3 participants