Provide custom OkHttpClient for MetricsReporter #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitoksmile
force-pushed
the
metrics/http-client
branch
2 times, most recently
from
5c44638 to
360ebf5
Compare
|
Test pipeline is failing Execution failed for task ':coverallsJacoco'. > COVERALLS_REPO_TOKEN not set |
|
Happy to approve. Could use a test proving that the passed client is used for posting. |
|
Thanks for contributing :) I will look into the token error |
|
@vitoksmile Please merge main back to this branch so you get the new workflow (that doesn't run the coveralls on external PRs) |
vitoksmile
force-pushed
the
metrics/http-client
branch
from
bcb6966 to
f2855ec
Compare
|
@andreas-unleash rebased into main |
|
The failure is only in your fork. Maybe you need the workflows there as well |
|
@andreas-unleash will you include this change into next release? |
|
Yes. Probably shortly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
We have a way to set custom
OkHttpClientforUnleashClient, however we are missing it forHttpMetricsReporter. CustomOkHttpClientis usefull when we want to add our ownInterceptor(e.g.HttpLoggingInterceptor).