Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/location service #60

Open
wants to merge 8 commits into
base: version/0.2.0
Choose a base branch
from

Conversation

tonelli-m
Copy link
Collaborator

Description

Adds user location services for all three platforms

Changes

  • Added a UserLocationProvider interface with an implementation for each platform to deliver location updates. The location data that can be fetched varies a bit depending on the platform, see model/Location.kt for details.
  • For Android, previously we used a Foreground Service wrapper for AudioSource in order to leave it running when the app is in the background. This PR moves the foreground service wrapping to MeasurementRecordingService instead, so that the service is only running when an active recording is ongoing, and not just when microphone audio is monitored. See AndroidMeasurementRecordingService for more details.

Linked issues

#59

Remaining TODOs

  • The values for location accuracy and frequency are arbitrary for now but we can tweak those later

Checklist

  • Code compiles correctly on all platforms
  • All pre-existing tests are passing
  • If needed, new tests have been added
  • Extended the README / documentation if necessary
  • Added code has been documented

@tonelli-m tonelli-m added KMP Shared Kotlin code Android Android related code iOS iOS related code labels Dec 17, 2024
@tonelli-m tonelli-m added KMP Shared Kotlin code and removed KMP Shared Kotlin code labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Android related code iOS iOS related code KMP Shared Kotlin code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants