Internal/2022.3/staging #8078
Merged
Internal/2022.3/staging #8078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backports DOCG-1014 work to 2022.3 URP Docs
Backports work from DOCG-5645 ( #49638 ) Documents URP Config package more clearly and makes some minor version specific changes
Backports for fixes URP Docs table formatting to 2022.3
…anager Begin/End Camera and Context callbacks SingleCameraRequest on URP are rendering a single camera, it's purpose is rendering a camera without the full list of stack cameras. This avoid some overhead. As we are rendering 1 single camera, we are missing: ``` RenderPipelineManager.beginContextRendering RenderPipelineManager.endContextRendering RenderPipelineManager.beginCameraRendering RenderPipelineManager.endCameraRendering ``` Jira Issue: https://jira.unity3d.com/browse/UUM-69268 I've added a new docs page in URP with an exaple of how to use SubmitRenderRequest and how to subscribe to RenderPipelineManager callbacks in each case.
Minor style guide and link fixes Backport Accessible Language update to replace "see" with "refer to"
Backport relevant changes from https://github.cds.internal.unity3d.com/unity/unity/pull/48447/.
Backport Rendering Debugger Docs Changes to 2022.3 Docs
Fix for incorrect way to check if XR is enabled in the DrawObjects pass. This caused multiples issues: https://jira.unity3d.com/browse/UUM-69843 https://jira.unity3d.com/browse/UUM-71891 https://jira.unity3d.com/browse/UUM-71927
…ming back from a Maximized state The `OnDisable` is called just after the on Enable when coming back from a Maximized state. Making events unsubscribed.
…rror This PR backports cross platform Foveated Rendering functions to added in Unity 6 and adjusts URP soft particle shader code to make use of these functions which handle using y-flip adjusted UV coordinates automatically. These functions are located in `FoveatedRendering.hlsl` This fixes shader compiler errors on some foveated rendering platforms where there is a discrepancy between the Metal foveated rendering functions and those on other platforms.
This is a backport of a this PR: https://github.cds.internal.unity3d.com/unity/unity/pull/48294 Adds a new set of samples - Production Ready Shaders - to the Shader Graph package. The Shader Graph Production Ready Shaders sample is a collection of Shader Graph shader assets that are ready to be used out of the box or modified to suit your needs. You can take them apart and learn from them, or just drop them directly into your project and use them as they are. The sample also includes a step-by-step tutorial for how to combine several of the shaders to create a forest stream environment.  Documentation: https://docs.google.com/document/d/1vAwWO39TUg8VTlzznlKHBmwYftgHfFZ7eoLJNd_DhIU Blog Post (draft): https://docs.google.com/document/d/1F8yArILrt19uNWzd0yfu59KmjuRjUOxQo9Y84-y6Zao Video to announce the content: https://drive.google.com/drive/folders/1T2Y4x3gGAJmA1ikQv5485CTRganBRLfg https://docs.google.com/document/d/1WxKL3xZ0GV84lgV3VoCcP_5n6mxpo87gPeoUpI9F7tA Jiras associated with this project: https://jira.unity3d.com/browse/GSG-822 https://jira.unity3d.com/browse/PLATGRAPH-2851 https://jira.unity3d.com/browse/PLATGRAPH-3045 https://jira.unity3d.com/browse/PLATGRAPH-3046 https://jira.unity3d.com/browse/PLATGRAPH-2793 https://jira.unity3d.com/browse/PLATGRAPH-2205
…nalCopyDepth pass Backport of #48821 Fixed UUM-57147
Jira ticket: https://jira.unity3d.com/browse/UUM-36914 Initial context + initial fix + explanation: https://github.cds.internal.unity3d.com/unity/unity/pull/25910 More context for the Vulkan Terrain edge case: https://ono.unity3d.com/unity/unity/pull-request/111240/_/graphics/vulkan/case-1205332 It looks like the fix was not working for Vulkan (Scene View + URP + Wireframe mode), due to the `UseGfxDeviceWireframeShader(device)` if statement. Basically, the wireframe was not rendering at all. Removing it and using the normal path (`BeginWireframeWithShader`) fixes it. `Before vs After`: 
|
It appears that you made a non-draft PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read the Contributing guide before making a PR.
Checklist for PR maker
need-backport-*label. After you backport the PR, the label changes tobackported-*.CHANGELOG.mdfile.Purpose of this PR
Why is this PR needed, what hard problem is it solving/fixing?
Testing status
Describe what manual/automated tests were performed for this PR
Comments to reviewers
Notes for the reviewers you have assigned.