Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing HDRP tutorial text UUM-70814 #8071

Merged
merged 2 commits into from
May 15, 2024
Merged

Conversation

iM0ve
Copy link
Contributor

@iM0ve iM0ve commented May 15, 2024

This PR only updates the HDRP tutorials, fixing typos and updating broken documentation links. No assets besides tutorial text are touched. Fixed UUM-70814.

@iM0ve iM0ve requested a review from LagueKristin May 15, 2024 08:53
Copy link
Collaborator

@LagueKristin LagueKristin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but we should update the ChangeLog.md and bump the template version (In ValidationExceptions.json and package.json) so you can publish the sample with the new updates. We have this handy guide for the publishing here .

@iM0ve iM0ve requested a review from LagueKristin May 15, 2024 09:30
@iM0ve
Copy link
Contributor Author

iM0ve commented May 15, 2024

Made the updates, let me know if I missed something :)

Copy link
Collaborator

@LagueKristin LagueKristin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic :)

@LagueKristin LagueKristin merged commit b0544be into master May 15, 2024
1 check passed
@LagueKristin LagueKristin deleted the hdrp-tutorial-fixes branch May 15, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants