Internal/2023.2/staging #8037
Merged
Internal/2023.2/staging #8037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s active This PR makes it a bit more obvious in UI and tooltips that the light culling mask doesn't work in Forward+. If all active renderers are Forward+, then the culling mask setting in the light inspector is greyed out with the following tooltip:  If even one of the active renderers is something other than Forward+, then the setting is enabled again. But the tooltip also mentions that Forward+ doesn't support the setting: 
Backport of #42373 and #39818 Users have complained about performance issues on some platforms due to a change in SH Evaluation mode causing them to use PerPixel instead of PerVertex. This PR makes sure those platform use PerVertex when set to Auto. This PR does the following: - Adds a few platforms to ShAutoDetect to use PerVertex when Auto is selected. - Renames `XRPlatformBuildTimeDetect` to `PlatformBuildTimeDetect` as it's now used for more than XR. - Fixes a few typos and indentation. - Adds missing ScreenSpace Decals keyword when unused variants should be included in builds.
Fixes highlighting on HLSL code samples in URP Docs
…ertex is selected (UUM-63822) Fixes UUM-63822.
This PR prevents shaders used in the SDF Baker to compile on OpenGLES3. They were not supported nor tested on this platform. This avoid getting warnings like `Shader warning in 'GenSdfRayMap': HLSLcc: The resource 'rayMap' uses an unsupported type/format for read/write access at kernel RayMapScanX (on gles3)`. Warnings on **other platforms**, mentionned in this bug (https://jira.unity3d.com/browse/UUM-53994) are already fixed. Warnings on GLES3 about buffer count are not fixed, and will not be fixed.
partial backport of https://github.cds.internal.unity3d.com/unity/unity/pull/36370/ Uses the new multiscattering approx to have much more efficient precomputation, and lower memory usage
Fix CPU spikes when disabling a lot of decals: https://forum.unity.com/threads/deactivating-decal-projectors-causes-big-cpu-spikes.1545542/
*[See [this document](https://docs.google.com/document/d/1C4Vc7dOKgoZ2mNqMdugHDg-w6iN7iUYdlBQMGDmVS3E/edit) for details on what can land in 2023.3.]* This PR fixes an issue where the correct textures set from the ShaderGraph shader are not properly updated for use in the TilemapRenderer.
This PR fixes a potential out-of-bounds buffer access in Forward+'s clustering code that caused a GPU crash on certain platforms, e.g. Metal on Apple Silicon. There was an existing clamp that was logically incorrect. This PR corrects that clamp and adds a code comment for some reasoning behind the fix.
Add a link from the URP upgrade page back to the main manual error shader page, and back. Jira ticket: https://jira.unity3d.com/browse/DOCG-1012
*[See [this document](https://docs.google.com/document/d/1C4Vc7dOKgoZ2mNqMdugHDg-w6iN7iUYdlBQMGDmVS3E/edit) for details on what can land in 2023.3.]* *[Description of feature/change. Links to screenshots, design docs, user docs, etc. Link to Jira if applicable. Remember reviewers may be outside your team, and not know your feature/area that should be explained more.]*
Equivalent issue with those fixed in https://github.cds.internal.unity3d.com/unity/unity/pull/39775/ and needed for this PR: https://github.cds.internal.unity3d.com/unity/unity/pull/38459/ Relative to https://devblogs.microsoft.com/directx/hlsl-2021-migration-guide/
Current trunk behavior: https://media.github.cds.internal.unity3d.com/user/42/files/780f4466-dcdd-4f49-af9b-8a2cfed6d3a7 Even if it's technically true, it isn't really a problem for VFXPropertyBinder. They won't change by themselves and they are only modifying exposed properties of a VFXComponent.
…e Mask during normal rendering Fixes UUM-63214
Our light masking is too complicated at the moment. Users, our own QA folks and our own engineers are confused by it. Here's quite a [highly voted feature request](https://issuetracker-mig.prd.it.unity3d.com/issues/urp-light-culling-mask-does-not-work-when-using-forward-plus-rendering-path) that asks for support in Forward+. The twist: This is already well-supported! See below the pseudocode of how this actually works. All the complexity goes away when you ignore culling mask, which is more of a legacy concept, and always rely on the rendering layer mask, which is a newer and better feature. ```c // Rendering the mesh // ------------------ if (camera.cullingMask & meshRenderer.layer) { // Draw the mesh renderer in the game view } else { // Skip drawing the mesh renderer in the game view } // Lighting the mesh // ----------------- if (pipeline == Forward) { if (light.cullingMask & meshRenderer.layer) { if (light.renderingLayers && meshRenderer.renderingLayerMask) { // Light the mesh renderer with this light } else { // Skip lighting the mesh renderer with this light } } else { // Skip lighting the mesh renderer with this light } } else { // pipeline == Deferred or pipeline == ForwardPlus if (light.renderingLayers && meshRenderer.renderingLayerMask) { // Light the mesh renderer with this light } else { // Skip lighting the mesh renderer with this light } } ``` This PR makes the following changes: 1. It moves the Rendering Layers inspector field on top of the Culling Mask field. They used to be under completely different headers.  2. It shows a greyed out Rendering Layers field even when the "Use Rendering Layers" setting is off on the URP asset. In this condition, the field was totally invsible. My change improves visibility of this feature substantially.  3. If the culling mask is set to anything other than the default value of Everything, we now show a warning box advising the use of Rendering Layers instead. 
… AfterRenderingPostProcessing This PR fixes a regression with the FinalPost pass introduced [here](https://github.cds.internal.unity3d.com/unity/unity/pull/30667) **Details:** FinalPost is supposed to execute after the AfterRenderingPostProcessing injection point, so making sure final post is the last thing that runs before AfterRendering *Also changing the main post pass injection to "AfterRenderingPostProcessing - 1" instead of "AfterRenderingPostProcessing - 2" as there's no need to squeeze 2 passes there anymore
…y when using Alpha Clipping This modification addresses an issue where certain alpha-to-coverage specific logic was unintentionally overwriting the alpha value utilized by transparent surfaces that also employed alpha-clipping. The resolution for this issue involves incorporating the alpha overwrite logic directly into the calculations specific to alpha-to-coverage. Bug: https://jira.unity3d.com/browse/UUM-56601 Backport: https://jira.unity3d.com/browse/UUM-57487
…and add link from shadows page Improvements to screen space shadows page, and add link from shadows page We have another ticket to improve shadow pages and structure (https://jira.unity3d.com/browse/DOCG-1026), so this is just a small ticket to tidy up the page, make mobile performance clearer, and link from the main shadows page. Jira ticket: https://jira.unity3d.com/browse/DOCG-1025
Fix Broken Links in URP Docs on the **Install URP into an existing project** page
…ctors JIRA: UUM-61466 When motion vectors are required and a depth-less offscreen texture is used as the camera target, a default depth format should be provided to motion vectors.
…UUM-64447) Fixes UUM-64447. The issue was that the `_ALPHATEST_ON` keyword needs to be available in both vertex and fragment shaders in order to check if UV (TEXCOORD1) is needed or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read the Contributing guide before making a PR.
Checklist for PR maker
need-backport-*label. After you backport the PR, the label changes tobackported-*.CHANGELOG.mdfile.Purpose of this PR
Why is this PR needed, what hard problem is it solving/fixing?
Testing status
Describe what manual/automated tests were performed for this PR
Comments to reviewers
Notes for the reviewers you have assigned.