Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal/2022.3/staging #8023

Merged
merged 10 commits into from
Jan 19, 2024
Merged

Internal/2022.3/staging #8023

merged 10 commits into from
Jan 19, 2024

Conversation

UnityAljosha
Copy link
Collaborator

Please read the Contributing guide before making a PR.

Checklist for PR maker

  • Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • Have you updated the changelog? Each package has a CHANGELOG.md file.
  • Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the Docs team contacts sheet.
  • Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.

Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?


Testing status

Describe what manual/automated tests were performed for this PR


Comments to reviewers

Notes for the reviewers you have assigned.

ellioman and others added 10 commits January 10, 2024 14:35
…hange when the Scene is reloaded

Fixes UUM-49000
Regular docs sync to main
Backport of https://github.cds.internal.unity3d.com/unity/unity/commit/720d3219c91d69e442a8c32a86e5497dc362c4e1 for [UUM-58478](https://jira.unity3d.com/browse/UUM-58478)
NOTE: This fix was part of the following trunk fix: [32011](https://github.cds.internal.unity3d.com/unity/unity/pull/32011)

Small fix to ensure that player doesn't fail on error;
`Library\PackageCache\[email protected]\Runtime\XR\XRMirrorView.cs(3,19): error CS0234: The type or namespace name 'XR' does not exist in the namespace 'UnityEngine' (are you missing an assembly reference?)`

Bug: [UUM-58478](https://jira.unity3d.com/browse/UUM-58478)
Backport: [UUM-60124](https://jira.unity3d.com/browse/UUM-60124)
Partial backport of https://github.cds.internal.unity3d.com/unity/unity/pull/25124

The backport fixes the sRGB conversion when PostProcessing is turned off (either globally or on the camera). In this case the `FinalBlit` path was used, which had no sRGB conversion in the blitting shaders.
It also fixes debug views, which also not worked with PostProcessing turned off.

The backport is needed for one of our customers (Stellantis) who reported that the screen is to dark when it is running on a device with a gamma space backbuffer. This was because the rendering path lacked a color conversion from the sRGB temp buffer to the backbuffer.
This is a backport of a change we have on trunk. No functional change until we add more .tar.zst files.
… Deferred Rendering (UUM-58537)

Fixes UUM-58537.
Sets up the StencilDeferred shader in the same way as is done in 2023 by splitting up the code in to a .hlsl file. Changes some multi compile declarations to defines.
@UnityAljosha UnityAljosha requested review from a team as code owners January 19, 2024 18:11
@UnityAljosha UnityAljosha merged commit 3b36d36 into 2022.3/staging Jan 19, 2024
4 checks passed
@github-actions github-actions bot added the sdet label Jan 19, 2024
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants