Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal/2021.3/staging #8020

Merged
merged 4 commits into from
Jan 11, 2024
Merged

Internal/2021.3/staging #8020

merged 4 commits into from
Jan 11, 2024

Conversation

UnityAljosha
Copy link
Collaborator

Please read the Contributing guide before making a PR.

Checklist for PR maker

  • Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • Have you updated the changelog? Each package has a CHANGELOG.md file.
  • Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the Docs team contacts sheet.
  • Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.

Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?

Testing status

Describe what manual/automated tests were performed for this PR

Comments to reviewers

Notes for the reviewers you have assigned.

kirill-titov-u and others added 4 commits January 2, 2024 15:24
@kirill-titov-u
[Backport][2021.3][RPW] Global Settings will always be ensured no ma…
347bd5c 
…tter what RP is active

AssetImportWorker is a completely separate process which will have their own instance of Render Pipeline.
Although, it can't ensure and migrate any asset. This operations should be performed on the main process. 
This means they should create Render Pipeline instance only after the main process migrated everything.
We are achieving this by always ensuring Global Settings no matter what Render Pipeline is active.
In addition, we need to save the assets otherwise Workers will not see the changes.
https://jira.unity3d.com/browse/UUM-47264
@theopnv
[21.3] Bump SRP packages to 12.1.14
f7eebf8 
Bump SRP packages to 12.1.14.
@RobJessop
2021.3/documentation staging
2c24a7c 
Regular docs sync to main.
@unity-cchu
Fixes multiply rendered shadows and missing shadows
d61be1a 
Fixes two bugs:

https://jira.unity3d.com/browse/D2D-4877 (UUM-59844)
https://jira.unity3d.com/browse/D2D-4817 (UUM-1855)
@UnityAljosha UnityAljosha requested review from a team as code owners January 11, 2024 07:52
@UnityAljosha UnityAljosha merged commit fdf92e2 into 2021.3/staging Jan 11, 2024
3 checks passed
@github-actions GitHub Actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@UnityAljosha @kirill-titov-u @theopnv @RobJessop @unity-cchu