Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal/2021.3/staging #8017

Merged
merged 3 commits into from
Jan 2, 2024
Merged

Internal/2021.3/staging #8017

merged 3 commits into from
Jan 2, 2024

Conversation

UnityAljosha
Copy link
Collaborator

Please read the Contributing guide before making a PR.

Checklist for PR maker

  • Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • Have you updated the changelog? Each package has a CHANGELOG.md file.
  • Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the Docs team contacts sheet.
  • Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.

Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?

Testing status

Describe what manual/automated tests were performed for this PR

Comments to reviewers

Notes for the reviewers you have assigned.

bencloward and others added 3 commits December 12, 2023 06:42
@bencloward
fixing typos in Node Reference sample
ce3fbe8 
Fixing typos in the Shader Graph Node Reference sample set. This is backport of the original fix:
Original PR in trunk: https://github.cds.internal.unity3d.com/unity/unity/pull/41289
Bug: [UUM-58644](https://jira.unity3d.com/browse/UUM-58644)
Forum post: https://forum.unity.com/threads/new-node-reference-samples.1516337/
@joshua-davis
UUM-56914 #comment Fixed BiRP shader graph target displaying specular…
ab47972 
Backport of https://github.cds.internal.unity3d.com/unity/unity/pull/40949.
[Jira Bug](https://jira.unity3d.com/browse/UUM-56618)
[Port](https://jira.unity3d.com/browse/UUM-56918)
@aceunity
[2021.3] Fix URP shader stripping performance
29a569c 
Fixes performance of URP shader stripping. The shader stripping was 2-3 orders of magnitudes slower as it should be, which was causing very slow player build times when using URP.
This also fixes the URP tests building timing out.
@UnityAljosha UnityAljosha requested review from a team as code owners January 2, 2024 12:24
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2024

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@UnityAljosha UnityAljosha merged commit 2465409 into 2021.3/staging Jan 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@UnityAljosha @bencloward @joshua-davis @aceunity