Fix Shader Errors Caused By Typo in EditorShaderVariables.hlsl

[aSimpleUsername]

---

Purpose of this PR

This PR was originally just to fix the obvious whitespace on line 2 that has somehow gone unnoticed

Turns out this didn't completely fix the 'undeclared identifier' shader errors I was getting when we building, so I've added the definitions into this file. I believe this is what was intended by the Unity developers.

If you look at when EditorShaderVariables.hlsl was created they removed the legacy variables out of ShaderVariables.hlsl and put them in EditorShaderVariables, but excluded the ones I'm adding in this change - and they didn't add them anywhere else.

I also simplified the else statement, because the way they've written it is redundant.

Just as a note: The ShaderGraph ShaderVariables still contain all these definitions.

---

Testing status

Fixing this locally resolved this issue.​

---

Comments to reviewers

Notes for the reviewers you have assigned.

[sebastienlagarde]

Hi, thanks for notifiying us on this mistake, could I ask in which context you are getting an error? Which platform / configuration are you trying to compile? We don't expect this file to be used at runtime
thanks a lot

[bmourit]

While fixing this, why not correct:
EDITOR_SHADER_VARAIBLES -> EDITOR_SHADER_VARIABLES

[aSimpleUsername]

Hi, thanks for notifiying us on this mistake, could I ask in which context you are getting an error? Which platform / configuration are you trying to compile? We don't expect this file to be used at runtime thanks a lot

Hi, no worries, Windows 64bit - The error shows when building, not runtime

[sebastienlagarde]

While fixing this, why not correct: EDITOR_SHADER_VARAIBLES -> EDITOR_SHADER_VARIABLES

yes, fixed this at the same time that I integrated the correction in our private repo. I ,also fixed the custom texture for shader graph

[sebastienlagarde]

Closing this PR, it have landed on private repo in this PR: https://github.cds.internal.unity3d.com/unity/unity/pull/35555