Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made it so that the scripting symbol for an optional dependency is removed if that dependency is removed. #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

binarynate
Copy link

No description provided.

…moved from the project if the optional dependency is removed.
@binarynate
Copy link
Author

You're welcome, Sercan, and thank you for understanding! With the removal of the VUPLEX_CCU in 3D WebView v4.4, it will no longer add a symbol that indicates it's been installed. The VUPLEX_CCU symbol was an unintended side effect of using the CCU library. I should give you a heads-up that even though the scripts in this project currently use #if VUPLEX_CCU, the VUPLEX_CCU symbol is already saved in the project's Player Settings, so #if VUPLEX_CCU is always true, even if 3D WebView hasn't been installed yet. To illustrate that, here are some screenshots from a fresh clone of the project:

Screen Shot 2023-03-17 at 4 11 57 PM

Screen Shot 2023-03-17 at 4 12 17 PM

But since the project is an example for integration with 3D WebView, I think it's reasonable that the scripts have compilation errors if 3D WebView isn't installed. For comparison, all of 3D WebView's example projects (like the Oculus webview example) are the same way. But if you want this project to detect 3D WebView dynamically, one option could be to add the CCU library to the project. CCU's master branch doesn't automatically remove a scripting symbol if the optional dependency is removed, but I submitted this PR to CCU to make it so that it removes the scripting symbol if the optional dependency is removed. If you want to incorporate CCU, I can help by sending you details on how to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant