-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: switch optimism testnet from kovan to goerli #217
base: main
Are you sure you want to change the base?
Conversation
@annieke is attempting to deploy a commit to the Uniswap Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just a few questions
logoUrl: optimismLogoUrl, | ||
statusPage: 'https://optimism.io/status', | ||
helpCenterUrl: 'https://help.uniswap.org/en/collections/3137778-uniswap-on-optimistic-ethereum-oξ', | ||
nativeCurrency: { name: 'Optimistic Kovan Ether', symbol: 'kovOpETH', decimals: 18 }, | ||
nativeCurrency: { name: 'Optimism Görli Ether', symbol: 'görOpETH', decimals: 18 }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does this symbol come from? Why does this use ö instead of oe, like the rest of the labels?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
goerli in this same file uses the symbol, copypastaed here for consistency
widgets/src/constants/chainInfo.ts
Line 93 in e434298
nativeCurrency: { name: 'Görli Ether', symbol: 'görETH', decimals: 18 }, |
'0x3b8e53b3ab8e01fb57d0c9e893bc4d655aa67d84', | ||
export const USDC_OPTIMISM_GOERLI = new Token( | ||
SupportedChainId.OPTIMISM_GOERLI, | ||
'0x7E07E15D2a87A24492740D16f5bdF58c16db0c4E', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where did you pull this address from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a usdc contract i deployed to unblock another team for testing: https://goerli-optimism.etherscan.io/address/0x7e07e15d2a87a24492740d16f5bdf58c16db0c4e#code
currently it's our canonical usdc token on optimism goerli https://github.com/ethereum-optimism/ethereum-optimism.github.io/blob/bf1d49a8cd99db70beb7ff8d7adb6fb9c22f1b78/optimism.tokenlist.json#L1870-L1880
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just unsure why the tests are no longer passing
e434298
to
6819a31
Compare
Switching Optimism testnet from Kovan to Goerli: https://dev.optimism.io/kovan-to-goerli/
interface PR: Uniswap/interface#4719