test SafeCallback #220
Merged
test SafeCallback #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saucepoint
commented
Jul 27, 2024
Comment on lines
+24
to
+27
| vm.startPrank(caller); | ||
| if (caller != address(manager)) vm.expectRevert(SafeCallback.NotPoolManager.selector); | ||
| safeCallback.unlockCallback(data); | ||
| vm.stopPrank(); |
There was a problem hiding this comment.
this is pretty neat from foundry, when fuzzing for addresses the fuzzer includes deployed contracts from setup! 😲
snreynolds
requested changes
Jul 31, 2024
| safeCallback = new MockSafeCallback(manager); | ||
| } | ||
|
|
||
| function test_unlock(uint256 num) public { |
There was a problem hiding this comment.
can we also just add an assert that the pool manager in SafeCallback is the address we expect/the pool manager address we initialized it with
snreynolds
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #183
Description of changes
Added a mock contract and tested that
SafeCallback.unlockCallback()is only accessible from PoolManager