Add transfer support #218
Merged
Add transfer support #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hensha256
reviewed
Jul 29, 2024
hensha256
reviewed
Jul 30, 2024
src/PositionManager.sol
Outdated
| @@ -50,6 +50,8 @@ contract PositionManager is | |||
|
|
|||
| IAllowanceTransfer public immutable permit2; | |||
|
|
|||
| uint256 public constant FULL_DELTA = type(uint256).max; | |||
There was a problem hiding this comment.
I do think youll find if you make this 0 gas should go down noticeably because of removing non-0 calldata bytes.
It should go down by (16-4) * 32) = 384
hensha256
reviewed
Jul 30, 2024
hensha256
reviewed
Jul 30, 2024
| @@ -376,7 +376,13 @@ contract PosMGasTest is Test, PosmTestSetup, GasSnapshot { | |||
|
|
|||
| function test_gas_mint_native_excess() public { | |||
| uint256 liquidityToAdd = 10_000 ether; | |||
| bytes memory calls = getMintEncoded(configNative, liquidityToAdd, address(this), ZERO_BYTES); | |||
There was a problem hiding this comment.
if you wanted to keep using the liquidity operations helpers you could always have it check if one of the currencies is native and add a sweep automatically? like in finalizeML if its a mint/increase
There was a problem hiding this comment.
but dont feel strongly about it if you dnt want to
There was a problem hiding this comment.
eh its fine for now, can maybe add it later
hensha256
reviewed
Jul 30, 2024
dianakocsis
reviewed
Jul 31, 2024
| @@ -338,4 +338,42 @@ contract IncreaseLiquidityTest is Test, PosmTestSetup, Fuzzers { | |||
| ); | |||
| } | |||
| } | |||
|
|
|||
| function test_mint_settleWithBalance() public { | |||
There was a problem hiding this comment.
can you also test test_increaseLiquidity_settleWithBalance()
dianakocsis
reviewed
Jul 31, 2024
hensha256
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decide what the final "resolve" actions are & share the FULL_DELTA logic with router
opening into actions router since this builds on that