This repository has been archived by the owner on Apr 25, 2024. It is now read-only.
Safe Mode #160
Closed
Safe Mode #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewilz
reviewed
Feb 6, 2024
|
change feels hefty, the odds of losing an ERC20 are so slim. The most minimally invasive change to the sdk IMO is to add a bool parameter to If we must be this thorough this looks fiiiiiine i guess 😏 but wouldnt want the sdk to get too out of hand with trying to every last unlikely case. |
ewilz
approved these changes
Feb 7, 2024
ewilz
reviewed
Feb 7, 2024
src/entities/protocols/uniswap.ts
Outdated
| @@ -53,6 +68,11 @@ export class UniswapTrade implements Command { | |||
| encode(planner: RoutePlanner, _config: TradeConfig): void { | |||
| let payerIsUser = true | |||
|
|
|||
| let safetyMode = this.options.safetyMode ?? SafetyModes.Normal | |||
| let inputETHSweep = safetyMode == SafetyModes.InputOutputSweeps || safetyMode == SafetyModes.AllSweeps | |||
There was a problem hiding this comment.
maybe we rename to shouldSweepETH and shouldSweepIntermediateTokens for readability, know it's a bool flag
|
per slack convo: could we enforce a certain slippage instead of sweeping erc20 tokens on intermediate swaps?? if so, the changes could possibly go in swapRouter.ts?? |
ewilz
suggested changes
Feb 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.