This repository has been archived by the owner on Apr 25, 2024. It is now read-only.
enable flat portion option on swaps #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongeric
approved these changes
Sep 27, 2023
| @@ -107,6 +115,25 @@ export class UniswapTrade implements Command { | |||
| } | |||
| } | |||
|
|
|||
| // If there is a flat fee, that absolute amount is sent to the fee recipient | |||
| // In the case where ETH is the output currency, the fee is taken in WETH (for gas reasons) | |||
There was a problem hiding this comment.
hmm, so the fee transfer happens after the swap but before the unwrap?
| @@ -251,6 +251,23 @@ describe('Uniswap', () => { | |||
| expect(methodParameters.value).to.eq(methodParametersV2.value) | |||
| }) | |||
|
|
|||
| it('encodes a single exactOutput ETH->USDC swap, with a flat fee', async () => { | |||
There was a problem hiding this comment.
maybe can add an exactOut, eth out test since we have that edge case where the fee is taken in WETH just to make sure its working with unwrap logic
marktoda
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it can be difficult to use PAY_PORTION with exactOut trades to be able to get a clean output amount for the swapper, since we're always taking a percentage of total amount out (exact + fee %). So we must work backwards from that total amount, and since bips don't have very high precision, it becomes very hard to get the swapper their exactOut wihtout imprecision.
This PR allows taking a flat fee to accomplish clean numbers on exactOut trades.