Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump sor to 4.6.2 - bump sdk-core to 5.8.3 for worldchain and unichain sepolia SwapV2Router02 #748

Merged
merged 4 commits into from
Oct 15, 2024

Conversation

jsy1218
Copy link
Member

@jsy1218 jsy1218 commented Oct 11, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix

  • What is the current behavior? (You can also link to an open issue here)
    wrong SwapV2Router02 on worldchain and unichain sepolia

  • What is the new behavior (if this is a feature change)?
    right SwapV2Router02 on worldchain and unichain sepolia

  • Other information:

Copy link
Member Author

jsy1218 commented Oct 11, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jsy1218 and the rest of your teammates on Graphite Graphite

@jsy1218 jsy1218 changed the title 4.6.2 chore: bump sor to 4.6.2 - bump sdk-core to 5.8.3 for worldchain and unichain sepolia SwapV2Router02 Oct 11, 2024
@jsy1218 jsy1218 marked this pull request as ready for review October 11, 2024 22:44
@jsy1218 jsy1218 requested a review from a team as a code owner October 11, 2024 22:44
Copy link

socket-security bot commented Oct 11, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@uniswap/[email protected] None +14 1.35 MB uniswap-labs-owner-account, uniswap-labs-service-account

🚮 Removed packages: npm/@uniswap/[email protected]

View full report↗︎

@graphite-app graphite-app bot requested review from xrsv and cgkol October 11, 2024 22:47
Copy link

graphite-app bot commented Oct 11, 2024

Graphite Automations

"Request reviewers once CI passes on smart-order-router repo" took an action on this PR • (10/11/24)

3 reviewers were added and 1 assignee was added to this PR based on 's automation.

@jsy1218
Copy link
Member Author

jsy1218 commented Oct 14, 2024

we probably want to shoehorn updated v4 sepolia deploy addresses into the same PR. TBD on protocol team's v4 re-deploy exact time tomorrow.

UPDATE: protocol team does not plan to re-deploy v4 today, hence no v4-related sdks bump today. cc @cgkol

@jsy1218 jsy1218 changed the title chore: bump sor to 4.6.2 - bump sdk-core to 5.8.3 for worldchain and unichain sepolia SwapV2Router02 chore: bump sor to 4.6.2 - bump sdk-core to 5.8.3 for worldchain and unichain sepolia SwapV2Router02 and bump ur-sdk for sepolia v4 re-deploy Oct 14, 2024
@jsy1218 jsy1218 changed the title chore: bump sor to 4.6.2 - bump sdk-core to 5.8.3 for worldchain and unichain sepolia SwapV2Router02 and bump ur-sdk for sepolia v4 re-deploy chore: bump sor to 4.6.2 - bump sdk-core to 5.8.3 for worldchain and unichain sepolia SwapV2Router02 Oct 15, 2024
@jsy1218 jsy1218 merged commit af35daf into main Oct 15, 2024
27 of 29 checks passed
@jsy1218 jsy1218 deleted the siyujiang/sor-4.6.2 branch October 15, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants