-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rootstock
chain
#516
Add Rootstock
chain
#516
Conversation
cc: @jsy1218 for review. |
@ahsan-javaiid there's some genuine error, sourced from Unit Tests:
Don't worry about Integration Tests failure, as you don't have the JSON RPC URLs in your forked repo. However Unit Tests are self-contained, and should be able to pass. |
@jsy1218 |
You can use the static subgraph provider class to work around. However I realized that our external providers don't support RootStock yet, which means token balances, staticcall RPC calls (e.g. multicall) won't be available in routing yet. |
@jsy1218 Would be great to know which external providers are required for routing here. ? Thanks |
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Description
This PR adds
Rootstock
chain support to smart-order-router. PreviouslyRootstock
is added and released under https://github.com/Uniswap/sdk-core as Uniswap v3 contracts deployed to Rootstock.Reference:
Uniswap/sdk-core#123