Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base sepolia addresses #494

Closed
wants to merge 2 commits into from

Conversation

danielcrt
Copy link

@danielcrt danielcrt commented Feb 19, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Add support for Base Sepolia using the addresses from this PR: Add Base Sepolia addresses sdk-core#110

  • What is the current behavior? (You can also link to an open issue here)
    No support for Base Sepolia

  • What is the new behavior (if this is a feature change)?
    Support Base Sepolia ulticall.

  • Other information:

@danielcrt danielcrt requested a review from a team as a code owner February 19, 2024 10:10
@danielcrt danielcrt changed the title add base sepolia addresses Add base sepolia addresses Feb 19, 2024
@jsy1218
Copy link
Member

jsy1218 commented Feb 20, 2024

There was a BASE_GOERLI PR, that was closed due to not sufficient LP liquidities. Can you add LP liquidities on BASE_SEPOLIA?

@danielcrt
Copy link
Author

@jsy1218 I saw there's also no liquidity on Ethereum Sepolia for ETH/USDC

What would be the min requirements to move this forward?
Is 1 ETH/USDC (0.3%) LP on Base Sepolia enough or do I have to create multiple tiers?
What's the min liquidity I have to provide?

I can create a ETH/USDC pool on Base Sepolia with ~100 ETH / 100 USDC.

@jsy1218
Copy link
Member

jsy1218 commented Feb 22, 2024

@jsy1218 I saw there's also no liquidity on Ethereum Sepolia for ETH/USDC

What would be the min requirements to move this forward? Is 1 ETH/USDC (0.3%) LP on Base Sepolia enough or do I have to create multiple tiers? What's the min liquidity I have to provide?

I can create a ETH/USDC pool on Base Sepolia with ~100 ETH / 100 USDC.

~0.1 ETH / 300 USDC should be good enough. A single fee tier should be fine, I would create 0.05% instead of 0.3%, since 0.05% WETH/USDC is the most popular fee-tier pool on v3 L1.

@danielcrt
Copy link
Author

I saw the WETH/USDC pool is already initialized: https://sepolia.basescan.org/address/0x94bfc0574ff48e92ce43d495376c477b1d0eeec0
But with a very bad ratio:
0.000000000000000001 WETH
0.900001 USDC

I tried to mint a new position and add liquidity in order to balance the pool but without success. Can you please guide me how to fix this imbalance? Or what other solution can I work towards?

Copy link

stale bot commented Jun 16, 2024

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix This will not be worked on label Jun 16, 2024
@stale stale bot closed this Jun 24, 2024
@danielcrt danielcrt mentioned this pull request Aug 16, 2024
alex-stone added a commit to alex-stone/uniswap-sdks that referenced this pull request Nov 5, 2024
This adds the Chain ID, Addresses, and WETH token configuration for
the Base Sepolia network (84532).

This uses the addresses referenced in the Base Deployments doc:
https://docs.uniswap.org/contracts/v3/reference/deployments/base-deployments

This also uses this as the source for the WETH token on base sepolia:
https://sepolia.basescan.org/token/0x4200000000000000000000000000000000000006

This is following up on the changes that were being made on the old
SDK repos:
Uniswap/sdk-core#110
Uniswap/smart-order-router#494
alex-stone added a commit to alex-stone/uniswap-sdks that referenced this pull request Nov 5, 2024
This adds the Chain ID, Addresses, and WETH token configuration for
the Base Sepolia network (84532).

This uses the addresses referenced in the Base Deployments doc:
https://docs.uniswap.org/contracts/v3/reference/deployments/base-deployments

This also uses this as the source for the WETH token on base sepolia:
https://sepolia.basescan.org/token/0x4200000000000000000000000000000000000006

This is following up on the changes that were being made on the old
SDK repos:
Uniswap/sdk-core#110
Uniswap/smart-order-router#494
alex-stone added a commit to alex-stone/smart-order-router that referenced this pull request Nov 5, 2024
This adds the Chain ID, Addresses, and WETH token configuration for
the Base Sepolia network (84532) to the smart order router.

Uniswap#494
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants