Fix: Remove token validator provider calls from token properties provider #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsy1218
changed the title
jsy1218
changed the title
mikeki
reviewed
Sep 25, 2023
mikeki
approved these changes
Sep 26, 2023
jsy1218
deleted the
jsy1218/fix-token-properties-provider-failure-mode-caching
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
Token validator providers can return out-of-order results for the input token addresses. Coupled with the long caching TTL across all token properties entries, it can provider very negative experiences to the clients.
What is the new behavior (if this is a feature change)?
Token properties provider remove the calls to token validator providers. Also enhanced the
NodeJSCacheto accept per-entry TTL, so that token properties provider can set differentiated per-entry TTL depending on if it's positive cache or negative cache.Other information:
tested on the routing-api integ-test side via personal AWS account.