-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(breaking): esm/cjs builds for uniswapx-sdk #218
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
8a61942
to
9af312f
Compare
a1cd516
to
bb5c9f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me, but let's def discuss this as a group in terms of if this should be a major version bump or not!
4973c99
to
c4941d1
Compare
c4941d1
to
3bc5140
Compare
Graphite Automations"Request reviewers once CI passes on sdks monorepo" took an action on this PR • (12/16/24)1 reviewer was added and 1 assignee was added to this PR based on Siyu Jiang (See-You John)'s automation. |
PR Scope
breaking change to build structure for
uniswapx-sdk
Description
updates the build setup for
uniswapx-sdk
to manually and explicitly create separate cjs and esm builds (plus a types-only version)How Has This Been Tested?
built the sdk locally, then installed the local build result in another project (
universe/apps/web
) and verified that it properly resolved the esm version instead of the cjs versionAre there any breaking changes?
there shouldn't be, but technically if an end user is importing incorrectly (by directly referencing the
uniswapx-sdk.esm.js
file) then they'll need to update(Optional) Follow Ups
PRs to follow will do this for many other SDKs