feat(v3-sdk): add insufficient liquidity handling #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved insufficient liquidity error handling by updating error checks and throw conditions. Modified return values in `v3Swap` to include `amountSpecifiedRemaining` and made necessary adjustments in pool and trade logic to reflect these changes.
shuhuiluo
force-pushed
the
insufficient-liquidity
branch
from
5fa79bc to
9168b71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improved insufficient liquidity error handling by updating error checks and throw conditions. Modified return values in
v3Swapto includeamountSpecifiedRemainingand made necessary adjustments in pool and trade logic to reflect these changes.How Has This Been Tested?
Unit tests.
Are there any breaking changes?
No.