-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide "Delete dashboard" button for default dashboard #3234
Hide "Delete dashboard" button for default dashboard #3234
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Test results 9 files 9 suites 8m 20s ⏱️ Results for commit 2a3fe46. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3234 +/- ##
=======================================
Coverage 60.30% 60.30%
=======================================
Files 605 605
Lines 43685 43685
Branches 48 48
=======================================
Hits 26343 26343
Misses 17330 17330
Partials 12 12 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooof, that means I have to look at the javascript code again 😅 |
1162b47
to
6c55c5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup 👍
9dd0596
to
7a071c4
Compare
7a071c4
to
2a3fe46
Compare
Quality Gate passedIssues Measures |
Dependent on #3233. Another potential part of the fix for #3150.
This hides the "Delete dashboard" button for the default dashboard. Up for discussion if this is how we want to prevent the user from trying to delete the default dashboard.
But this is how it is done for the case where the current dashboard is the last dashboard.
Before:
After: