Wash list of theme names #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elfjes
suggested changes
Nov 6, 2024
hmpf
force-pushed
the
wash-themes-list
branch
2 times, most recently
from
34c422e
to
e77e0c8
Compare
elfjes
reviewed
Nov 13, 2024
elfjes
suggested changes
Nov 13, 2024
src/argus_htmx/themes/utils.py
Outdated
| DATA_THEME_RE = f"\[data-theme={THEME_NAME_RE}\]" | ||
|
|
||
| static_url = Path(settings.STATIC_URL).relative_to("/") | ||
| stylesheet_path = static_url / default_htmx_settings.STYLESHEET_PATH |
There was a problem hiding this comment.
this needs to look at the django.conf.settings since it might be overridden in another settings file (we do this)
elfjes
suggested changes
Nov 13, 2024
There was a problem hiding this comment.
Overall I like this.
There's one thing though. it seems that check_for_valid_themes_list is scheduled to run after the Models are instantiated. which means that argus_htmx.themes.constants is imported, which runs get_theme_names, which throws the ImproperlyConfigured error and now we don't get our nice error message.
|
Also lolololol the check breaks the maybe it should be a warning instead? |
elfjes
reviewed
Nov 13, 2024
hmpf
force-pushed
the
wash-themes-list
branch
from
e4d5440
to
095ffa1
Compare
elfjes
suggested changes
Nov 14, 2024
elfjes
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the themes shown in the theme-selector are actually installed.