Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linting of CSS and HTML files using MegaLinter #137

Closed
wants to merge 6 commits into from

Conversation

johannaengland
Copy link
Contributor

@johannaengland johannaengland commented Sep 12, 2024

Closes #40.

djLint will be used to format and lint HTML files and stylelint to lint CSS files. I have not added formatting of CSS files since that is not supported in MegaLinter as far as I found out and otherwise I am too unsure what to use to format CSS files.

MegaLinter is currently failing because linting some HTML files produces errors. I would like some help to fix these errors or to tell me that these rules can be ignored.

@johannaengland johannaengland added the polish Nice to have label Sep 12, 2024
@johannaengland johannaengland self-assigned this Sep 12, 2024
Copy link

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ CSS stylelint 1 0 1.32s
❌ HTML djlint 40 9 2.24s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@johannaengland
Copy link
Contributor Author

I just saw that only one CSS file has been linted - src/argus_htmx/tailwindtheme/styles.css, because src/argus_htmx/static/styles.css is in .gitignore. Which CSS files should be actually linted?

@johannaengland
Copy link
Contributor Author

We have decided to not format CSS files and use djLint by itself to lint/format HTML files

@johannaengland johannaengland deleted the workflows/megalinter branch October 8, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
polish Nice to have
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Linting/Code formatting
1 participant