Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add router and interface poll feature #88

Merged
merged 8 commits into from
Jun 12, 2024
Merged

Add router and interface poll feature #88

merged 8 commits into from
Jun 12, 2024

Conversation

podliashanyk
Copy link
Contributor

@podliashanyk podliashanyk commented Apr 3, 2024 •
edited
Loading

Closes #65

Depends on Uninett/zinolib#53

@podliashanyk podliashanyk added enhancement New feature or request beta Part of beta release usability testing Needs or is a part of UX testing labels Apr 3, 2024
@podliashanyk podliashanyk self-assigned this Apr 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 19.23077% with 21 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@1cbd8b9). Learn more about missing BASE report.

Files Patch % Lines
src/howitz/endpoints.py 19.23% 21 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #88   +/-   ##
=======================================
  Coverage        ?   46.44%           
=======================================
  Files           ?       15           
  Lines           ?      915           
  Branches        ?        0           
=======================================
  Hits            ?      425           
  Misses          ?      490           
  Partials        ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@podliashanyk podliashanyk mentioned this pull request Apr 3, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024 •
edited
Loading

Test results

  4 files    4 suites   8s ⏱️
14 tests 14 ✔️ 0 💤 0 ❌
56 runs  56 ✔️ 0 💤 0 ❌

Results for commit f06ae16.

♻️ This comment has been updated with latest results.

@podliashanyk podliashanyk marked this pull request as ready for review April 4, 2024 13:48
@lunkwill42 lunkwill42 changed the title Add poll feature Add router and interface poll feature May 21, 2024
hmpf
hmpf reviewed May 22, 2024
View reviewed changes
src/howitz/endpoints.py Outdated Show resolved Hide resolved
@podliashanyk podliashanyk mentioned this pull request May 22, 2024
Open
@podliashanyk podliashanyk added the paused Assignee is busy with things of higher priority label Jun 6, 2024
@podliashanyk podliashanyk removed the paused Assignee is busy with things of higher priority label Jun 12, 2024
@podliashanyk podliashanyk requested a review from hmpf June 12, 2024 07:59
@podliashanyk podliashanyk merged commit 3ac00e7 into main Jun 12, 2024
5 checks passed
@podliashanyk podliashanyk deleted the add-poll branch June 12, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmpf hmpf hmpf approved these changes

@lunkwill42 lunkwill42 Awaiting requested review from lunkwill42

@stveit stveit Awaiting requested review from stveit

@johannaengland johannaengland Awaiting requested review from johannaengland

Assignees

@podliashanyk podliashanyk

Labels
beta Part of beta release enhancement New feature or request usability testing Needs or is a part of UX testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add manual poll functionality
3 participants
@podliashanyk @codecov-commenter @hmpf