Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for libcurl should only happen if DAP and/or ncZarr are enabled. #3018

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Check for libcurl should only happen if DAP and/or ncZarr are enabled. #3018

merged 2 commits into from
Sep 11, 2024

Conversation

WardF
Copy link
Member

@WardF WardF commented Sep 11, 2024

Thanks to @edwardhartnett for pointing out that #2907 only addressed cmake-based builds.

@WardF WardF added this to the 4.9.3 milestone Sep 11, 2024
@WardF WardF self-assigned this Sep 11, 2024
@WardF
Clean up and reorganize a bit, add logic so that byterange support is…
36297b0 
… disabled when the functionality it requires has been disabled.
@WardF WardF merged commit 6f63ca6 into Unidata:main Sep 11, 2024
107 checks passed
@WardF WardF deleted the fixlibcurl.wif branch September 11, 2024 21:57
DennisHeimbigner
DennisHeimbigner reviewed Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@DennisHeimbigner DennisHeimbigner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok, but frankly I don't know if it captures all the dependencies correctly. At some point, we need to deal with the enormous set of dependencies in both the makefile and CMakeList.txt.

@WardF WardF mentioned this pull request Sep 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DennisHeimbigner DennisHeimbigner DennisHeimbigner left review comments

Assignees

@WardF WardF

Labels
None yet
Projects
None yet
Milestone
4.9.3
Development

Successfully merging this pull request may close these issues.

-lcurl included in libraries, even when remote access disabled
2 participants
@WardF @DennisHeimbigner