[pull] master from monkeytypegame:master #560
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Co-authored-by: Jack <[email protected]>
… (#5856) * fix(caret): getting last letter top in long multiline words (@NadAlaba) * no need to check for invisible extra letters This check was needed when `letterPosTop` was `currentLetter?.offsetTop ?? previousLetter?.offsetTop ?? lastWordLetter?.offsetTop` where `previousLetter?.offsetTop` was defined but 0 in extra letters in blind mode, so we got the value of zero although in some fonts the real value (`lastWordLetter` value) is not 0. However, now we don't use `previousLetter`, and `currentLetter` is undefined in extra letters (blind mode or not), so we'll get the value we want (`lastWordLetter` value) in extra letters. * update comment
Co-authored-by: Christian Fehmer <[email protected]> Co-authored-by: Christian Fehmer <[email protected]>
…he leaderboards actually closes #5858
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Christian Fehmer <[email protected]>
Co-authored-by: Nad Alaba <[email protected]> Co-authored-by: Christian Fehmer <[email protected]> Co-authored-by: Igor Bedesqui <[email protected]> Co-authored-by: amarnathsama <[email protected]>
Added the Roman version of Urdu (urdish - similar to Hinglish). More about Urdish: https://en.wikipedia.org/wiki/Urdish - [x] Adding a language or a theme? - [x] If is a language, did you edit _list.json, _groups.json and add languages.json? - [x] Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.
fix: Correcting spelling and formal errors ### Description Correcting spelling errors (according to Hunspell swiss german corrector in LibreOffice) and replacing phrases with corresponding words. By the way: the link in the "_comment" is a dead link. I'm not sure if that was somewhat a living link in the past. You won't find it in the Wayback Machine (archive.org) either. ### Checks - [ ] Adding quotes? - [ ] Make sure to include translations for the quotes in the description (or another comment) so we can verify their content. - [ ] Adding a language or a theme? - [ ] If is a language, did you edit `_list.json`, `_groups.json` and add `languages.json`? - [ ] If is a theme, did you add the theme.css? - Also please add a screenshot of the theme, it would be extra awesome if you do so! - [x] Check if any open issues are related to this PR; if so, be sure to tag them below. - [x] Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info) - [x] Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.
### Description Removes catched english quotes in the french quotes file
feat: Add a quote of Patent Ochsner in the file. ### Description Just add one quote from Patent Ochsner to lighten up everybody's day (translation): "A glass to love and one to the full life. And one to that which we cannot hold. One gate opens and another closes. You stay in my heart, even when it starts to hurt." ### Checks - [x] Adding quotes? - [x] Make sure to include translations for the quotes in the description (or another comment) so we can verify their content. - [ ] Adding a language or a theme? - [ ] If is a language, did you edit `_list.json`, `_groups.json` and add `languages.json`? - [ ] If is a theme, did you add the theme.css? - Also please add a screenshot of the theme, it would be extra awesome if you do so! - [x] Check if any open issues are related to this PR; if so, be sure to tag them below. - [x] Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info) - [x] Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.
- moved group definitionsg to the shared pacakge - made sure typescript will throw errors if a config is left without a group - removed the 'missing group' check because its not possible anymore
this fixes issues with drop downs causing performance / duplication issues
### Description <!-- Please describe the change(s) made in your PR --> ### Checks - [ ] Adding quotes? - [ ] Make sure to include translations for the quotes in the description (or another comment) so we can verify their content. - [ ] Adding a language or a theme? - [ ] If is a language, did you edit `_list.json`, `_groups.json` and add `languages.json`? - [ ] If is a theme, did you add the theme.css? - Also please add a screenshot of the theme, it would be extra awesome if you do so! - [ ] Check if any open issues are related to this PR; if so, be sure to tag them below. - [x] Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info) - [x] Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title. <!-- label(optional scope): pull request title (@your_github_username) --> <!-- I know I know they seem boring but please do them, they help us and you will find out it also helps you.--> Closes # <!-- pro tip: you can press . (dot or period) in the code tab of any GitHub repo to get access to GitHub's VS Code web editor Enjoy! :) -->
fixes rare bug where every key press would be considered a dead key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )