Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(blog) localstack #118

Merged
merged 6 commits into from
Dec 21, 2024
Merged

(blog) localstack #118

merged 6 commits into from
Dec 21, 2024

Conversation

UmairJibran
Copy link
Owner

No description provided.

@UmairJibran UmairJibran requested a review from Copilot December 21, 2024 15:14
@UmairJibran UmairJibran self-assigned this Dec 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • .nvmrc: Language not supported
Comments suppressed due to low confidence (6)

_blogs/localstack-your-gateway-to-cloud-testing.md:60

  • The link 'L' seems unnecessary and should be removed.
Docker installed on your machine [L](#references)

_blogs/localstack-your-gateway-to-cloud-testing.md:27

  • [nitpick] Consider rephrasing to 'Developing with live AWS resources can incur significant costs, especially during frequent testing.'
Developing on live AWS resources can incur significant costs, especially during frequent testing.

src/lib/api.ts:25

  • The return type of getBlogBySlug should be updated to Story | null to reflect the possibility of returning null.
export function getBlogBySlug(slug: string): Story | null {

src/lib/api.ts:49

  • The return type of getCaseStudyBySlug should be updated to Story | null to reflect the possibility of returning null.
export function getCaseStudyBySlug(slug: string): Story | null {

src/lib/api.ts:44

  • The sort function in getAllBlog should check if blog1.date and blog2.date exist before comparing them to avoid potential errors.
blog1.date > blog2.date ? -1 : 1,

src/lib/api.ts:71

  • The sort function in getAllCaseStudies should check if caseStudy1.date and caseStudy2.date exist before comparing them to avoid potential errors.
caseStudy1.date > caseStudy2.date ? -1 : 1,
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-river-0640ed603-118.westeurope.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-river-0640ed603-118.westeurope.azurestaticapps.net

@UmairJibran UmairJibran requested a review from Copilot December 21, 2024 15:28

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • .nvmrc: Language not supported
Comments suppressed due to low confidence (2)

src/lib/api.ts:34

  • Ensure that the error handling behavior (returning null) in getBlogBySlug is covered by tests.
return null;

src/lib/api.ts:58

  • Ensure that the error handling behavior (returning null) in getCaseStudyBySlug is covered by tests.
return null;
@UmairJibran UmairJibran merged commit 166440b into master Dec 21, 2024
4 checks passed
@UmairJibran UmairJibran deleted the blog-localstack branch December 21, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant