Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update windows-install-hosts.bat reference #704

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update windows-install-hosts.bat reference #704

wants to merge 1 commit into from

Conversation

emmanuel-ferdman
Copy link

PR Summary

Small PR - fixes the broken windows-install-hosts.bat reference in the docs.

spirillen
spirillen approved these changes Nov 23, 2024
View reviewed changes
Copy link
Contributor

@spirillen spirillen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emmanuel-ferdman
Copy link
Author

@funilrys @mitchellkrogza please review this small PR when you get the chance

spirillen

This comment was marked as resolved.

Sign in to view

@emmanuel-ferdman
Copy link
Author

@spirillen I did change /templates/README_template.md in this PR. Should I just revert the /README.md?

@spirillen
Copy link
Contributor

@spirillen I did change /templates/README_template.md in this PR. Should I just revert the /README.md?

No no, my bad. but when I was looking at https://github.com/Ultimate-Hosts-Blacklist/Ultimate.Hosts.Blacklist/pull/704/files I didn't notice you was working on the template :)

Just sit back a relax with a cup of coffee

@emmanuel-ferdman
Copy link
Author

@spirillen ok, let me know if you need anything else from my side 😄

@spirillen
Copy link
Contributor

/merge

@emmanuel-ferdman
Copy link
Author

@spirillen looks like it didn't merge, please check when you get the chance

@spirillen
Copy link
Contributor

@spirillen looks like it didn't merge, please check when you get the chance

I can't merge this one, only @mitchellkrogza and maybe @funilrys have that magic power here, I was just Santa's little helper

@emmanuel-ferdman
Copy link
Author

@spirillen thank you!
@mitchellkrogza @funilrys could you please review this small PR? 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spirillen spirillen spirillen requested changes

@funilrys funilrys Awaiting requested review from funilrys funilrys is a code owner

@mitchellkrogza mitchellkrogza Awaiting requested review from mitchellkrogza mitchellkrogza is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Ultimate-Hosts-Blacklist Backlog (public)
Status: 🚫 Blocked / Waiting
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emmanuel-ferdman @spirillen