fix: cast number param for dateadd to int for databricks DNA-15944 (DNA-20849) #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dennis-UiPath
approved these changes
Nov 17, 2023
JasperSelmanUiPath
deleted the
fix/add_int_casting_for_dateadd_databricks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explicitly cast
numberto INT in thedateaddmacro for the Databricks part. Without this cast, we cannot use thedateaddfunction with day, week, month, quarter or year in combination with theto_integerpm_utils macro. That last macro returns aBIGINTwhich is not accepted by the functions used in the implementation for the specified periods.Release
main)dev(or other) branchDid you consider?
- [ ] What is the performance impact?dbt_project.yml