Implement dateadd macro DNA-15944 [DNA-20679] #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silviustanimir
force-pushed
the
feat/dateadd
branch
8 times, most recently
from
64d0b5b
to
3de08a2
Compare
Dennis-UiPath
requested changes
Nov 16, 2023
README.md
Outdated
| @@ -79,6 +80,12 @@ In case you want to create the index on a source table, refer to the table using | |||
| ) }} | |||
| ``` | |||
|
|
|||
| #### dateadd ([source](macros/multiple_databases/dateadd.sql)) | |||
| This macro adds a specified number value (as a signed integer) to a specified datepart of an input date value, and then returns that modified value. The datepart can be any of the following values for SQL Server and Snowflake: year, quarter, month, week, day, hour, minute, second, millisecond. For Databricks, the datepart can be any of the following values: year, day, hour, minute, second. | |||
There was a problem hiding this comment.
We are expecting a date or a datetime as input for this function, right? Can this be mentioned here explicitly. Now it states "input date value" and in the example uses "expression" (which can be a string)
| @@ -0,0 +1,22 @@ | |||
| {%- macro dateadd(datepart, number, datetime_field) -%} | |||
| {%- if target.type == 'snowflake' -%} | |||
| dateadd({{ datepart }}, {{ number }}, try_to_timestamp(to_varchar({{ datetime_field }}))) | |||
There was a problem hiding this comment.
If we know the datetime_field is a date or a datetime, we can use to_timestamp({{datetime_field}})
| {%- elif target.type == 'sqlserver' -%} | ||
| dateadd({{ datepart }}, {{ number }}, try_convert(datetime2, {{ datetime_field }})) | ||
| {%- elif target.type == 'databricks' -%} | ||
| {%- set clock_component -%} |
There was a problem hiding this comment.
can we rename this value to time_value? It represents the time only part of the datetime
| dateadd({{ datepart }}, {{ number }}, try_convert(datetime2, {{ datetime_field }})) | ||
| {%- elif target.type == 'databricks' -%} | ||
| {%- set clock_component -%} | ||
| to_unix_timestamp({{ datetime_field }}) - to_unix_timestamp(date_trunc('DD', {{ datetime_field }})) |
There was a problem hiding this comment.
If we convert the input value using to_unix_timestamp, we will lose the millisecond precision. This makes it different from the Snowflake and SQL Server implementations
silviustanimir
force-pushed
the
feat/dateadd
branch
6 times, most recently
from
4c5b27d
to
86f7c1d
Compare
README.md
Outdated
| @@ -86,6 +87,12 @@ In case you want to create the index on a source table, refer to the table using | |||
| ) }} | |||
| ``` | |||
|
|
|||
| #### dateadd ([source](macros/multiple_databases/dateadd.sql)) | |||
| This macro adds a specified number value (as a signed integer) to a specified datepart of an input date or datetime, and then returns that modified value. The datepart can be any of the following values for SQL Server and Snowflake: year, quarter, month, week, day, hour, minute, second, millisecond. For Databricks, the datepart can be any of the following values: year, quarter, month, week, day, hour, minute, second, millisecond. | |||
There was a problem hiding this comment.
- Adds a number to a datepart --> Adds a specified number value of the specified datepart ...?
- The list of options supported is the same for Snowflake, SQL Server and Databricks, so we only need to list them once.
There was a problem hiding this comment.
Actually there are more for SQL Server, but I will remove the second list.
silviustanimir
force-pushed
the
feat/dateadd
branch
from
86f7c1d
to
e6611d2
Compare
silviustanimir
force-pushed
the
feat/dateadd
branch
from
30d2c4f
to
d23b18c
Compare
Dennis-UiPath
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Release
main)dev(or other) branchDid you consider?
What is the performance impact?The version number indbt_project.yml