Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: optional without casting (DNA-18184: DNA-18273) #56

Merged
merged 5 commits into from
Aug 30, 2023
Merged

fix: optional without casting (DNA-18184: DNA-18273) #56

merged 5 commits into from
Aug 30, 2023

Conversation

cverhoef
Copy link
Contributor

Description

  • Update the optional() implementation to prevent data type casting on a field that can be selected when relation is not a source.
  • This is to prevent potential 2nd data type casting on already casted fields. 2nd data type casting is a problem for date, time, and datetime fields when a format variable is provided different from the database standard (Snowflake only).

Release

  • Direct release (main)
  • Merge to dev (or other) branch
    • Why:

Did you consider?

  • Does it Work on Automation Suite / SQL Server
  • Does it Work on Automation Cloud / Snowflake
  • What is the performance impact?
  • The version number in dbt_project.yml

@cverhoef cverhoef merged commit 207c2e0 into main Aug 30, 2023
2 checks passed
@cverhoef cverhoef deleted the fix/optional_without_casting branch August 30, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KosmasH KosmasH KosmasH approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cverhoef @KosmasH