Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule frontend #6

Merged
merged 11 commits into from
May 21, 2024
Merged

Schedule frontend #6

merged 11 commits into from
May 21, 2024

Conversation

pautorne
Copy link
Contributor

No description provided.

Copy link

netlify bot commented May 17, 2024

Deploy Preview for mypets-geiade ready!

Name Link
🔨 Latest commit 4915b38
🔍 Latest deploy log https://app.netlify.com/sites/mypets-geiade/deploys/664cadb89e4c5f000828d915
😎 Deploy Preview https://deploy-preview-6--mypets-geiade.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@diegogliarte
Copy link
Contributor

Its producing this errors:

Error: bundle initial exceeded maximum budget. Budget 2.00 MB was not met by 173.29 kB with a total of 2.17 MB.

It seems like the dependency 'moment' you added is messing up with the build. Maybe change the backend for another date format, and then you will be able to simply use 'date'? I see that you are using ZonedDateTime:

image

I used LocalDateTime and didnt have to the 'moment' module:

image

@rogargon
Copy link
Member

@diegogliarte and @pautorne, I will extend the size of the application budget to accommodate this additional dependency. That can be done during development and, later, we can try to optimise the application size.
Regarding date formats, always try to use ZonedDateTime to avoid inconsistencies when dealing with users in different time zones. This way, they will be converted in the front end to their local time but stored in an unambiguous format.

rogargon added 3 commits May 21, 2024 16:01
# Conflicts:
#	src/app/app-routing.module.ts
#	src/app/app.module.ts
#	src/app/navbar/navbar.component.html
@rogargon rogargon merged commit c9cdfc6 into main May 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants