Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crud Location #3

Merged
merged 3 commits into from
Feb 22, 2024
Merged

crud Location #3

merged 3 commits into from
Feb 22, 2024

Conversation

globox97
Copy link
Contributor

No description provided.

@globox97 globox97 changed the title Basic creation for the classes I've been assigned crud Location Feb 20, 2024
Copy link
Contributor

@jorgechp jorgechp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Just take into consideration some details:

  1. We need to extend from UriEntity, so that all classes can be treated as an URI in the future. (take a look here and follow the same model https://github.com/UdL-EPS-SoftArch/seedbank-geiade-api/blob/main/src/main/java/cat/udl/eps/softarch/demo/domain/Batch.java )
  2. It's better to use Long instead of Integer when using identifiers (same than in 1, take a look to Batch class).
  3. Use one PR per class. If you are on crud-Location, try to focus only on Location class.

Thanks!

@gdbogdan gdbogdan linked an issue Feb 21, 2024 that may be closed by this pull request
@rogargon rogargon requested a review from jorgechp February 22, 2024 07:39
@rogargon rogargon merged commit a394647 into main Feb 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crud Location
4 participants