Ubpa::detail::constexpr_value_name now can receive a constexpr enum value #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alue as a template parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ubpa::detail::constexpr_value_name now can receive a constexpr enum value as a template parameter。添加这个的原因是UDRefl这个反射库依赖了这个函数，而这个函数不能接收enum常量参数，导致反射库在有些情况下会编译不通过，我在隔壁提了issue：Ubpa/UDRefl#20
在编译期获取enum值的字符串的方法是从magic_enum库中找到的。