-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor with minor improvements, and add README #5
Conversation
There should be subsequent "breaking" PRs, including a better config representation (maybe TOML?), transferring some responsibilities to the API server, more customization, etc. |
cc @taoky . I’m especially unsure about the role of |
API server and recovery backend are two different applications, though currently they're using the same |
So the API server also requires |
I'm fine if you're splitting it into two tokens and mark |
Yes. |
The recovery-sshd server lives in another private repo. It accepts plain SSH requests with username being one of Not sure why we didn't open-source recovery-sshd. The repo contains no secret beyond what could certainly be deemed "implementation details". |
Done. |
@taoky We can merge this PR at any time, but before we deploy it you'll have to update our Django server to adapt to the new API request/response schema. |
@iBug I don’t think we introduced any breaking change since v0.0.7…? All the features and improvements are purely additional. |
Would you like a chance to reorganize these commits so that they're suitable for a merge commit? Or would you mind if this large change shows as a single commit in the history? |
I would always prefer a squash merge:) If you don’t mind, please clean up the message body so it won’t be flooded by those commits. |
This PR intends to re-organize all the codes into different "submodules". Most notably, it removes all global variables and wraps all the functionalities into classes with minor changes to the behavior, enabling more precise testing.
recovery-token
is added as an optional configuration, andlogger
is no longer required.This PR also adds a concrete README on all the configurable options and the API design.