-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PROXY protocol support #4
Conversation
This PR is almost finished and ready for review. It was marked as draft because I may want to discuss how extra functionalities may be integrated into upstream |
I prefer having |
Since In this way only one server instance is required, and users can mux standard and proxied downstream with custom strategies. |
This is a much better idea. I'd love to see it implemented this way. |
cf88bc3
to
f046d7d
Compare
Note that this PR doesn't have a clean commit history so a squash merge should be preferred. |
6dafcd4
to
96a3a1f
Compare
3b1f650
to
6f42590
Compare
Yep, this is certainly better. At least it no longer runs two TCP listeners in one process. Bring it in if you'd like. |
I would suggest add a simple documentation (README?) for current config and HTTP API. It looks like a bit more complex than before. |
Maybe in a separate PR? Changes in this PR is fully opt-in, and existing users don't need to change anything after upgrading. |
@taoky Is it okay to merge in the current state? I'm working on gardening the whole package (including splitting helpers into different files) which should be suitable of adding documentations. |
PROXY protocol, originally developed by HAProxy, extends the TCP protocol to explicitly preserve source (and destination) IPs when it's proxied.
This PR adds bidirectional PROXY protocol support to
sshmux
, opt-in by the API server and configuration file.