Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to code-review working group page #1645

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Aariq
Copy link

@Aariq Aariq commented Jan 9, 2025

Description

This adds links to resources for learning more about code review to the code review working group's page

Checklist:

  • I have previewed changes locally or with CircleCI (runs when PR is created)
  • I have completed any content reviews, such as getting input from relevant working groups. If no, please note this and wait to post the PR to the #website channel until the content has been settled.

When you are ready for a technical review/merge, post the for the link for the PR in the US-RSE Slack (#website) to ask for reviewers.

@Aariq
Copy link
Author

Aariq commented Jan 9, 2025

I don't know if this should go under the "Work Products" header or if "Code Review Resources" should also be a level 1 header.

@exoticDFT
Copy link
Member

Thanks for starting this @Aariq . After looking at this, and thinking a bit more, I wonder if listing all the resources on the website directly this way is the best path forward. I think it will be great having the resources as visible as possible, but I'm a bit concerned that this will make it hard to update in the future when we find more resources.

Could it make sense to create a curated document or spreadsheet that we "publish" and link to, or maybe better, embed on the page here?

What do others think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants