Py open sci review #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RC review: Update README.md with badges
Docs link and format issues link
TADA repo is now EPATADA to be unique for CRAN
* Update broken link * Update Harmonize_Pensacola.Rmd * remove full path * Update requirements.txt Be more specific about lowest version * Update requirements.txt pin older version (32 vs 64 changes for dtype) * Update domains.py Interesting new domain was added... * Minor edits to text * Fix plot * Install from deve version not pinned release (one less thing to update) * Resolve first error when knit locally * Comment out some of the option 2 code so it doesn't run when knit-ing. Open to better options of how to format it as code but not always run it.. * First attempt to render the rmd in R (i.e. run the python code in R vignette) * Update test_r.yaml Try without renv, fixed typo. * Update test_r.yaml Switch from pip to conda (required of reticulate) * Update test_r.yaml Try setting up env using reticulate instead of conda (since conda-incubator is currently restricted) * Update test_r.yaml Combine install/run so env is not lost * Update test_r.yaml update env name * Update test_r.yaml Combine again without typo * Update test_r.yaml use miniconda_install() (note before I was setting up venv) * Update test_r.yaml install dev package from repo... for tests this should use the currently checked out instead, but just trying to get it working. * Update test_r.yaml Not sure why now it was case sensitive... * Update test_r.yaml pytest already check tests in test.yml, no need to run it a second time here. * Update test_r.yaml Skip unbutu, run all windows (conda) * Update test_r.yaml Trying on ubuntu again * Update test_r.yaml Try on older ubuntu version. * Update test_r.yaml bump action version up (getting warnings) * Update test_r.yaml Drop Ubuntu. Fix where python version is set from the matrix. Conda create with python version from matrix. * Update test_r.yaml Try setting var from matrix using with since it seemed to cut out 3.1* for 3.10. * Update test_r.yaml Try again (hoping it won't truncate python 3.1x this time. * Update test_r.yaml try as sting? * Dynamic config pyproject.toml Use dynamic to specify depends from requirements.txt. This should be more maintainable. and may resolve some of the install issues reveries were having. setuptools>=61.0 already required. * Update test_r.yaml Upload artifact at end to examine rendered html * Update artifact test_r.yaml Based on examples on repo * Update test_r.yaml * Update test_r.yaml Only upload on one runner (win 3.11 * Wordsmith Harmonize_Pensacola.Rmd Updated text to be more accurate with how reticulate can be used * separators Harmonize_Pensacola.Rmd No separators for list to conda --------- Co-authored-by: Romain Caneill <[email protected]> Co-authored-by: cristinamullin <[email protected]>
…eg F' changed. Re-ran all results to update. Closes #73
This was
linked to
issues
Jul 5, 2024
Closed
Adding example code for dev env. Closes #63
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comparing for PR