Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge from main #81

Merged
merged 43 commits into from
Jul 5, 2024
Merged

merge from main #81

merged 43 commits into from
Jul 5, 2024

Conversation

jbousquin
Copy link
Collaborator

No description provided.

rcaneill and others added 30 commits April 30, 2024 16:47
Be more specific about lowest version
pin older version (32 vs 64 changes for dtype)
Interesting new domain was added...
Fix tests - Update requirements
…. Open to better options of how to format it as code but not always run it..
Try without renv, fixed typo.
Switch from pip to conda (required of reticulate)
Try setting up env using reticulate instead of conda (since conda-incubator is currently restricted)
Combine install/run so env is not lost
update env name
Combine again without typo
use miniconda_install() (note before I was setting up venv)
install dev package from repo... for tests this should use the currently checked out instead, but just trying to get it working.
Not sure why now it was case sensitive...
pytest already check tests in test.yml, no need to run it a second time here.
Skip unbutu, run all windows (conda)
Trying on ubuntu again
Try on older ubuntu version.
jbousquin added 13 commits July 3, 2024 11:54
bump action version up (getting warnings)
Drop Ubuntu. Fix where python version is set from the matrix. Conda create with python version from matrix.
Try setting var from matrix using with since it seemed to cut out 3.1* for 3.10.
Try again (hoping it won't truncate python 3.1x this time.
try as sting?
Use dynamic to specify depends from requirements.txt. This should be more maintainable. and may resolve some of the install issues reveries were having. setuptools>=61.0 already required.
Upload artifact at end to examine rendered html
Based on examples on repo
Only upload on one runner (win 3.11
Updated text to be more accurate with how reticulate can be used
No separators for list to conda
@jbousquin jbousquin merged commit 7e187a2 into pyOpenSci-review Jul 5, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants