Merge pull request #85 from USEPA/pyOpenSci-review

Py open sci review
USEPA · Jul 9, 2024 · 3917228 · 3917228
2 parents 646a5c3 + 5b79f0f
commit 3917228
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/harmonize_wq/domains.py b/harmonize_wq/domains.py
@@ -136,9 +136,8 @@ def harmonize_TADA_dict():
     csv = f'{TADA_DATA_URL}develop/inst/extdata/HarmonizationTemplate.csv'
     df = pandas.read_csv(csv)  # Read csv url to DataFrame
     full_dict = {}  # Setup results dict
-    # Loop over one unique characteristicName at a time
-    for char in df['TADA.CharacteristicName'].unique():
-        sub_df = df[df['TADA.CharacteristicName']==char]  # Mask by char
+    # Build dict one unique characteristicName at a time
+    for char, sub_df in df.groupby('TADA.CharacteristicName'):
         full_dict[char] = char_tbl_TADA(sub_df, char)  # Build dictionary
 
     # Domains to check agaisnt

diff --git a/requirements_dev.txt b/requirements_dev.txt
@@ -4,4 +4,5 @@ sphinx
 sphinx_rtd_theme
 sphinxcontrib-spelling
 nbsphinx
-nbsphinx_link
+nbsphinx_link
+notebook