Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to fix #682 - attempt 1 #179

Merged
merged 4 commits into from
Sep 28, 2023
Merged

Trying to fix #682 - attempt 1 #179

merged 4 commits into from
Sep 28, 2023

Conversation

nerik
Copy link

@nerik nerik commented Sep 28, 2023

This is reverting two routing related commits that might be causing NASA-IMPACT/veda-ui#682

See NASA-IMPACT/veda-ui#684

@netlify
Copy link

netlify bot commented Sep 28, 2023

Deploy Preview for ghg-demo ready!

Name Link
🔨 Latest commit 7e51174
🔍 Latest deploy log https://app.netlify.com/sites/ghg-demo/deploys/6515d5cf40034e0008660ea2
😎 Deploy Preview https://deploy-preview-179--ghg-demo.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nerik nerik changed the title Is this a fix? Trying to fix #682 - attempt 1 Sep 28, 2023
@hanbyul-here
Copy link
Collaborator

For the record: I left the previous temporary fixes (three links on the top nav as a tag) as they are, so people can compare this to the other links.

@nerik nerik merged commit 2cdb8cc into develop Sep 28, 2023
@nerik nerik deleted the ghg-sans-potential-bug branch September 28, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants